[AppBar] waterfall behaviour #1321
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import React from 'react'; | ||
| import {AppBar} from 'material-ui'; | ||
|
|
||
| import IconButton from 'icon-button'; | ||
| import MoreVertIcon from 'svg-icons/navigation/more-vert'; | ||
| import ArrowBack from 'svg-icons/navigation/arrow-back'; | ||
|
|
||
| const AppBarWaterfallExample = React.createClass({ | ||
|
|
||
| render() { | ||
| return ( | ||
| <AppBar | ||
| position="waterfall" | ||
| waterfall={{ | ||
| minHeight: 64, | ||
| maxHeight: 210, | ||
| children: this.getWaterfallChildren(), | ||
| onHeightChange: this.onHeightChange, | ||
| }} | ||
| title={ | ||
| <div | ||
| ref={el => { this.titleEl = el; }}> | ||
| Waterfall AppBar | ||
| </div> | ||
| } | ||
| iconElementLeft={ | ||
| <IconButton onClick={this.onBackClick}> | ||
| <ArrowBack /> | ||
| </IconButton> | ||
| } | ||
| iconElementRight={ | ||
| <IconButton> | ||
| <MoreVertIcon/> | ||
| </IconButton> | ||
| } | ||
| /> | ||
| ); | ||
| }, | ||
|
|
||
| getWaterfallChildren() { | ||
| let styles = this.getStyles(); | ||
| return ( | ||
| <div | ||
| style={{overflow: 'hidden'}}> | ||
|
There was a problem hiding this comment. place this in the getStyles() too please. |
||
| <img | ||
| ref={el => { this.logoEl = el; }} | ||
| style={styles.logo} | ||
| src="images/material-ui-logo.svg"/> | ||
| </div> | ||
| ); | ||
| }, | ||
|
|
||
| onHeightChange({height, minHeight, maxHeight}) { | ||
| let interpolation = (height - minHeight) / (maxHeight - minHeight); | ||
|
|
||
| // For best performance, we will directly modify style on DOM elements | ||
|
There was a problem hiding this comment. this does improve performance, but leave that to the users, I'd say lets just go with re-render here for brevity. Do you agree @oliviertassinari ? There was a problem hiding this comment. I needed this type of optimization for mobile version. But I will modify the example to add also the simple, un-optimized version, that just use setState and re-renders. There was a problem hiding this comment. yeah, providing the both ways to do it seems like a good idea 👍 Thanks |
||
| this.logoEl.style.transform = `translate3d(80px,0,0) scale3d(${interpolation}, ${interpolation}, 1)`; | ||
| this.logoEl.style.opacity = interpolation; | ||
| this.titleEl.style.opacity = 1 - interpolation; | ||
| }, | ||
|
|
||
| onBackClick() { | ||
| window.history.back(); | ||
| }, | ||
|
|
||
| getStyles() { | ||
| return { | ||
| logo: { | ||
| height: 120, | ||
| margin: '0 auto', | ||
| display: 'block', | ||
| transformOrigin: '25% 100% 0', | ||
| transform: 'translate3d(80px,0,0)', | ||
| }, | ||
| }; | ||
| }, | ||
| }); | ||
|
|
||
| export default AppBarWaterfallExample; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import React from 'react'; | ||
| import {AppCanvas, Styles, Mixins} from 'material-ui'; | ||
|
|
||
| import CodeExample from '../code-example/code-example'; | ||
| import FullWidthSection from '../full-width-section'; | ||
|
|
||
| import AppBarWaterfallExample from './app-bar-waterfall-example'; | ||
| import AppBarWaterfallExampleCode from '!raw!./app-bar-waterfall-example'; | ||
|
|
||
| const {StylePropable} = Mixins; | ||
| const {Typography} = Styles; | ||
| const ThemeManager = Styles.ThemeManager; | ||
| const DefaultRawTheme = Styles.LightRawTheme; | ||
|
|
||
| const AppBarWaterfall = React.createClass({ | ||
|
|
||
| mixins: [StylePropable], | ||
|
|
||
| getInitialState() { | ||
| let muiTheme = ThemeManager.getMuiTheme(DefaultRawTheme); | ||
| // To switch to RTL... | ||
| // muiTheme.isRtl = true; | ||
| return { | ||
| muiTheme, | ||
| }; | ||
| }, | ||
|
|
||
| contextTypes: { | ||
| router: React.PropTypes.func, | ||
| }, | ||
|
|
||
| childContextTypes: { | ||
| muiTheme: React.PropTypes.object, | ||
| }, | ||
|
|
||
| getChildContext() { | ||
| return { | ||
| muiTheme: this.state.muiTheme, | ||
| }; | ||
| }, | ||
|
|
||
| getStyles() { | ||
| return { | ||
| headline: { | ||
| //headline | ||
| fontSize: '24px', | ||
|
There was a problem hiding this comment. px unit is not needed for all the properties. For instance, this one |
||
| lineHeight: '32px', | ||
| paddingTop: '16px', | ||
| marginBottom: '12px', | ||
| letterSpacing: '0', | ||
| fontWeight: Typography.fontWeightNormal, | ||
| color: Typography.textDarkBlack, | ||
| }, | ||
| }; | ||
| }, | ||
|
|
||
| render() { | ||
| let styles = this.getStyles(); | ||
|
There was a problem hiding this comment. For unchanged variable, is better to use |
||
| return ( | ||
| <AppCanvas> | ||
| <AppBarWaterfallExample/> | ||
| <FullWidthSection> | ||
| <h2 style={styles.headline}>Waterfall AppBar</h2> | ||
|
|
||
| <p>Here is an example of how you can obtain a nice animation effect on scroll | ||
| when using position waterfall.</p> | ||
| <CodeExample code={AppBarWaterfallExampleCode}/> | ||
| </FullWidthSection> | ||
| </AppCanvas> | ||
| ); | ||
| }, | ||
| }); | ||
|
|
||
| export default AppBarWaterfall; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this back to app-bar, this breaks navigation in the components section