Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Fix a regression on Edge #11614

Merged
merged 1 commit into from
May 28, 2018

Conversation

oliviertassinari
Copy link
Member

I can't explain what's wrong with the Babel runtime toConsumableArray method nor why it doesn't fail in the CI. Something is really wrong. This is a workaround.

Closes #11607

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! labels May 28, 2018
@oliviertassinari
Copy link
Member Author

Ok, I have found it. Symbol.iterator in Object(document.querySelector('div').children) is false on Edge and true on Chrome.
This is the root of the problem. https://github.com/babel/babel/blob/7846eaebaa69662134782b35d9bdff9b71616aa1/packages/babel-runtime/helpers/builtin/iterableToArray.js#L2
I'm going to open an issue on Babel side.

@oliviertassinari oliviertassinari merged commit d7bf410 into mui:master May 28, 2018
@oliviertassinari oliviertassinari deleted the menu-edge branch May 28, 2018 19:39
@setvik
Copy link

setvik commented Jun 2, 2018

Do you know when the next release will be? Any possibility of fast-tracking a new release and deploying to npm? Affects iOS 10 and and below as well: about 4% of our user base.

@oliviertassinari
Copy link
Member Author

@setvik This weekend.

@oliviertassinari
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants