[SelectField] width fix #1031
Merged
[SelectField] width fix #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a defaultProps for full width? So we don't have to look to deep what is the default value? |
|
there you go |
|
Thanks |
|
@chrismcv Can you fix the docs site as well please? Thanks! |
|
@hai-cea ah - my default was to 100%... what do you think it should be? i think 100% is more usable generally. and can fix docs to suit that.... |
|
@chrismcv I think that SelectField should have the same default width as TextField. Therefore fullWidth false as default may be better. What do you think? |
|
updated to match text-field |
|
@chrismcv Thanks, can you reduce the number of commit to only one? |
|
sorted |
|
Thanks @chrismcv @oliviertassinari |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Created base <Picker /> component for rendering all possible views * Recreate TimePicker with new <Picker /> component * Add TimePicker toolbar and fully replace old TimePickerRoot * Fix not generating docs when exported several components * Redo DatePicker on <Picker /> * Grand Views Refactoring * Fix Root-Pickers tests * Fix ts errors * Fix Object(...) is not a function error * Fix loosing selected meridiem * Use wildcard import rather than default import (mui#1038) * [mui#1031] Fix className of ClockNumber selected state (mui#1045) * Bugfix/spread input props (mui#1046) * [mui#1031] Fix className of ClockNumber selected state * [mui#1039] Fix not passing down InputProps * Make InputProps not required * Redo DateTimePickerToolbar to use grid * Get rid of 'selected' and 'disabled' classes * Fix console warnings
zannager
added
the
component: select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select field currently forced width to 256px after recent refactor.