Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] defaultDate is actually value(date) #986

Closed
ustccjw opened this issue Jun 29, 2015 · 1 comment
Closed

[DatePicker] defaultDate is actually value(date) #986

ustccjw opened this issue Jun 29, 2015 · 1 comment
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!

Comments

@ustccjw
Copy link
Contributor

ustccjw commented Jun 29, 2015

as title, it should rename or change its behave

ps. onChange(null, value) is unnecessary, onChange(value) may be better.
@ustccjw ustccjw changed the title datepicker's defaultValue is actually value datepicker's defaultDate is actually value Jun 29, 2015
@ustccjw ustccjw changed the title datepicker's defaultDate is actually value datepicker's defaultDate is actually value(date) Jun 29, 2015
@jkruder jkruder changed the title datepicker's defaultDate is actually value(date) [DatePicker] defaultDate is actually value(date) Jul 8, 2015
@dylo0 dylo0 mentioned this issue Aug 31, 2015
Closed
@shaurya947
Copy link
Contributor

@ustccjw not sure what you mean.. if you check the docs today, the propType for the defaultDate prop has been updated to instanceOf(Date).

If you would like to change the function signature to onChange(value), we welcome PRs :-)

Closing for now. If I'm missing something, feel free to comment!

@oliviertassinari oliviertassinari mentioned this issue Jan 14, 2018
Merged
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
[#985] Fix circular reference of reexprted type (mui#986)
8ea5cf3
@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Dec 23, 2022
@maniator maniator mentioned this issue Jul 8, 2023
Open
@akashmitra akashmitra mentioned this issue Jul 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shaurya947 @ustccjw @zannager