Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Support for Google offical Material Icons font #829

Closed
quanglam2807 opened this issue Jun 11, 2015 · 7 comments
Closed

[Icons] Support for Google offical Material Icons font #829

quanglam2807 opened this issue Jun 11, 2015 · 7 comments
Labels
package: icons Specific to @mui/icons

Comments

@quanglam2807
Copy link
Contributor

Google recently released an official font for Material Icons and I think material-ui's FontIcon component should be modified to support this.
This is what I'm using now but it's tricky to use with iconClassName.

<div className="material-icons md-24">&#xE8B6;</div>

or

// > IE 9
<div className="material-icons md-24">search</div>
@mairh
Copy link

mairh commented Jun 12, 2015

+1

@metalmatze
Copy link
Contributor

I'm already using it like

<FloatingActionButton>
    <i className="material-icons" style={{color: 'white'}}>add</i>
</FloatingActionButton>

But integrating it would be really nice!

@mariusk
Copy link

mariusk commented Jun 14, 2015

This solution also works great with .classname:before { content: '...' } for the cases where this library does not pass on children (typically the ligature name).

@ilourt
Copy link

ilourt commented Jun 16, 2015

@metalmatze

I use your solution, but the icon is not centered in the button. Do you have the same problem?

@metalmatze
Copy link
Contributor

No, that not a problem. But when hovering the button, I get this annoying background.
screenshot from 2015-06-16 15-58-02
Otherwise it all seems fine to me.

@mariusk
Copy link

mariusk commented Jun 16, 2015

That kind of background is actually the same thing that happens when a button wraps an a tag tag (ref. discussion about <SomeButton><Link>...</Link></SomeButton> related to the react-router discussion in another issue.

@ilourt
Copy link

ilourt commented Jun 16, 2015

I find out the center problem. It is when I use the 'send' icon, for exemple with 'home' icon ther is no problem of centering.

@hai-cea hai-cea changed the title Support for Google offical Material Icons font [Icons] Support for Google offical Material Icons font Jun 19, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
…mui#829)

* [#824] Fix crashing if openning datepicker with error

* Make default datetimepicker example show today
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added package: icons Specific to @mui/icons and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

No branches or pull requests

7 participants