Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow] unused suppression in beta 6 #7854

Closed
oonsamyi opened this issue Aug 21, 2017 · 4 comments
Closed

[flow] unused suppression in beta 6 #7854

oonsamyi opened this issue Aug 21, 2017 · 4 comments
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: material-ui Specific to @mui/material

Comments

@oonsamyi
Copy link

oonsamyi commented Aug 21, 2017

Problem description

I have the following error related to flow:

Error: node_modules/material-ui/Card/Card.js.flow:21
 21: // $FlowFixMe - invalid error? claims raised prop is missing
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error suppressing comment. Unused suppression

Steps to reproduce

  1. Install version beta.6.
  2. Enter the command flow.

Versions

  • Material-UI: 1.0.0-beta.6,
  • Flow-bin: 0.52.0
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2017

@rsolomon
Copy link
Contributor

@oliviertassinari that's not the issue here. Flow checks when a suppression comment exists that's unnecessary. What the error is saying is that it found a suppression comment ($FlowFixMe), but it's above a line that doesn't actually throw an error in the first place.

@oliviertassinari
Copy link
Member

Could that be a flow missmatch version issue or we can simply remove the comment?

@rosskevin
Copy link
Member

Flow may have fixed a bug, which means the suppression is now unnecessary, so we just remove it.

Regardless, this will probably get fixed as #7788 is fixed (in progress today).

rosskevin added a commit to alienfast/material-ui that referenced this issue Aug 22, 2017
@zannager zannager added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: material-ui Specific to @mui/material labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

5 participants