-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LeftNav] Make composable #413
Comments
++1 |
Yeah I don't understand why this isn't the default behavior. +1 |
+1 |
Would love to see this, I'm trying to apply additional styles to the Menu that is currently wrapped in LeftNav, but there doesn't seem to be a way? |
+1 |
Also shouldn't the menu items of a leftnav be declared as elements instead of json passed as an attribute? <LeftNav>
<MenuItem 1/>
<MenuItem 2/>
<MenuItem 3/>
</LeftNav> |
+1 |
+1 I'd go even further than @olivierGM's suggestion:
This way I can put whatever content I like in there. |
#1319 composable LeftNave |
+1 |
1 similar comment
+1 |
This is now possible with the improved LeftNav. |
* Update dependecies, change component prop-types. * Helmet now has prop-types support. * Update yarn lockfile * Bumped react-router and forgot prop types in clientconfig. * Bump enzyme and prop-types * Bump react-async-component and enzyme
Is there a way to make the LeftNav component composable? I need to add a custom component into the LeftNav. Is there a way to add another MenuItemType or pass in children into the render function on the LeftNav?
The text was updated successfully, but these errors were encountered: