Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet Component #282

Closed
uuns opened this issue Jan 27, 2015 · 12 comments
Closed

Bottom Sheet Component #282

uuns opened this issue Jan 27, 2015 · 12 comments
Labels
duplicate This issue or pull request already exists

Comments

@uuns
Copy link

uuns commented Jan 27, 2015

any chance there's going to be bottom sheet behavior?

relevant links:

http://www.google.com/design/spec/components/bottom-sheets.html#bottom-sheets-specs

https://material.angularjs.org/#/demo/material.components.bottomSheet

angular/material#361

@hai-cea hai-cea added the new feature New feature or request label Jun 19, 2015
@hai-cea hai-cea changed the title bottom sheet Bottom Sheet Component Aug 7, 2015
@michaelntech
Copy link

+1

4 similar comments
@gitdistill
Copy link

+1

@thetwit4u
Copy link

+1

@AngelEyesChina
Copy link

+1

@ncrmro
Copy link

ncrmro commented Jan 3, 2016

+1

@dcrescim
Copy link

+1

2 similar comments
@coachdan
Copy link

+1

@ngimenez17
Copy link

+1

@mbrookes
Copy link
Member

Reminds me of this:

Issues often accumulate content-less “+1” comments which serve only to spam the maintainers and any others subscribed to the issue

https://github.com/dear-github/dear-github

I'm going to be blunt (because it's what I do best 👅): This is an open-source project, and "+1" is not a contribution. Crack open your editors and lets see which of you can come up with the best example, or better still, make a shared fork and work on it collaboratively.

Looking forward to what you come up with! 🎉 🎈

@oliviertassinari
Copy link
Member

@mbrookes I was going to be more rude 😁:
Only comment if you have something to add to the discussion.
Adding a vanilla 👍 to a thread that already has 10 👍’s, doesn’t really do much to advance the project. Unless what you’re posting moves the issue closer to resolution or the pull request closer to merge, don’t hit the green button. Just don’t do it.

@AngelEyesChina
Copy link

@mbrookes , @oliviertassinari : What you wrote makes sense. Since I'm one of the people who posted "+1" on this thread, I can explain that for my part, the idea is a basically a vote, in the hope to push up the priority of the specific issue.

There might already be such a mechanism on github that I'm not aware of. Is there?

@mbrookes
Copy link
Member

Moved to #2126.

@mbrookes mbrookes added the duplicate This issue or pull request already exists label Jan 31, 2016
@mbrookes mbrookes closed this as completed Feb 2, 2016
@oliviertassinari oliviertassinari removed the new feature New feature or request label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests