Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

bottomSheet: Implement long Bottomsheet #361

Closed
rschmukler opened this issue Oct 2, 2014 · 4 comments
Closed

bottomSheet: Implement long Bottomsheet #361

rschmukler opened this issue Oct 2, 2014 · 4 comments
Milestone

Comments

@rschmukler
Copy link
Contributor

As per the Bottom Sheet Specs, I would like some clarification regarding bottom sheet

When displaying a bottom sheet, it should animate upwards from the bottom edge of the screen. The previous content dims to give the user context of where they were previously and the modal nature of the choice. Tapping on the dimmed area dismisses the sheet, as does swiping down on the sheet. If the sheet contains more actions that can fit in the initial display, the sheet is scrollable. Scrolling should also pull up the sheet container and eventually cover the entire screen. When the action sheet covers the entire screen, add a dismiss button to the header, on the left hand side of the title.

Regarding the positioning of the close button, and the "header" - does the header refer to the title on the bottom sheet? If so, what if it doesn't have a title, such as these:

no-header

icon-based

When the action sheet covers the entire screen, add a dismiss button to the header, on the left hand side of the title.

What should the dismiss button look like? Does "go to the left of the title" that mean that it should push the title in more? There are only 16du to the left of the header.

Scrolling should also pull up the sheet container and eventually cover the entire screen.

This implies that it shouldn't cover the screen when it comes in initially - what height should the bottom sheet initially be? Is it fixed, or a percentage of the screen height?

@ajoslin
Copy link
Contributor

ajoslin commented Oct 2, 2014

By the way, use material-backdrop, found in backdrop.scss, for the backdrop.

@ajoslin ajoslin added this to the 0.4 milestone Oct 2, 2014
@ThomasBurleson ThomasBurleson modified the milestones: 0.5, 0.4 Oct 8, 2014
@rschmukler rschmukler self-assigned this Oct 14, 2014
@marcysutton
Copy link
Contributor

Sounds like we still have questions about the bottom sheet, specifically whether there should be a close button. We definitely need to handle exiting the bottom sheet with the keyboard--opening an issue for that.

@ThomasBurleson ThomasBurleson modified the milestones: 0.5, 0.7.0-rc1 Dec 8, 2014
@rschmukler rschmukler modified the milestones: 0.8.0, 0.7.0 Jan 8, 2015
@robertmesserle robertmesserle modified the milestones: 0.9.0, 0.8.0 Feb 19, 2015
@rschmukler rschmukler modified the milestones: 1.0-beta1, 0.9.0 Apr 2, 2015
@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , 1.0-beta1 Aug 10, 2015
@ThomasBurleson ThomasBurleson changed the title Bottom Sheet Spec Clarification bottomSheet: Implement long Bottomsheet Aug 10, 2015
@manish2535
Copy link

Is this issue still being worked on? Another thing, the bottom sheet does not animate upwards, it just display at a certain position.

@devversion
Copy link
Member

There is already a fix present for that. See #6484

@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , Backlog Jan 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants