Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-webkit- prefix not being added to 'transform' on iOS8 #2663

Closed
dwoodlock opened this issue Dec 26, 2015 · 6 comments
Closed

-webkit- prefix not being added to 'transform' on iOS8 #2663

dwoodlock opened this issue Dec 26, 2015 · 6 comments
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it

Comments

@dwoodlock
Copy link

I am building a Cordova app using the WKWebView plugin and using your LeftNav component. When I run the app on iOS8, the left menu is always visible even when I set the property open={false}. In troubleshooting, I discovered that you are using the 'transform' css property instead of '-webkit-transform' in this case. I didn't completely debug your code to determine the logic you use to decide between 'transform' and '-webkit-transform' but it is missing this perhaps edge case. If I run the app straight from safari, it works fine so it's something about this WKWebView on iOS8 perhaps. So my simple fix was to add the second line:
'transform: 'translate3d(' + x + 'px, 0, 0)',
'-webkit-transform': 'translate3d(' + x + 'px, 0, 0)',
to the styles assuming the browser would throw away the one it didn't want. It worked but you may want to fix it properly. Thanks.
Don

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 26, 2015
@oliviertassinari
Copy link
Member

Are you using the latest version? That may be an issue with our autprefixer tool.

It worked but you may want to fix it properly.

That would also be the occasion to solve #2336.

@harumando
Copy link

i have this issue too on blackberry cordova app. material-ui version - 0.14.4

@oliviertassinari
Copy link
Member

@harumando Could this be an issue with the autoprefixer tool we use https://github.com/rofrischmann/inline-style-prefixer?

@oliviertassinari oliviertassinari added the external dependency Blocked by external dependency, we can’t do anything about it label Feb 23, 2016
@tintin1343
Copy link
Contributor

@oliviertassinari : Is this still an issue? I remember we updated the inline-style-prefixer library recently.

@oliviertassinari
Copy link
Member

@tintin1343 Yeah, this issue is pretty old. I believe that it was fixed at the inline-style-prefixer level.

@dwoodlock
Copy link
Author

Yes – OK by me.

From: Olivier Tassinari [mailto:[email protected]]
Sent: Friday, April 22, 2016 2:45 PM
To: callemall/material-ui
Cc: Woodlock, Don (GE Healthcare); Author
Subject: Re: [callemall/material-ui] -webkit- prefix not being added to 'transform' on iOS8 (#2663)

@tintin1343https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tintin1343&d=CwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=bQuLCd7b2ehAXCAD1aeNrx49BkqReEHGd3hsO2qFScQ&m=ns2UT4HAT1mmbJunk30TLxB-68j41Rh2mIbkrmX7WMA&s=Ol0d9Dk1iSX5Bb4VrjQQZlbyiX0Gutng9leJyJS9yis&e= Yeah, this issue is pretty old. I believe that it was fixed at the inline-style-prefixer level.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_callemall_material-2Dui_issues_2663-23issuecomment-2D213565441&d=CwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=bQuLCd7b2ehAXCAD1aeNrx49BkqReEHGd3hsO2qFScQ&m=ns2UT4HAT1mmbJunk30TLxB-68j41Rh2mIbkrmX7WMA&s=j8cfT8z2Z6REynJEpyPEbwyLmWS0jBCM1jm7gudRXrY&e=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

4 participants