Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] https://material-ui.com/components/expansion-panels/ redirects to /components/accordion/ #21704

Closed
2 tasks
oren-l opened this issue Jul 7, 2020 · 6 comments
Labels
docs Improvements or additions to the documentation v4.x

Comments

@oren-l
Copy link

oren-l commented Jul 7, 2020

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔

Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v4.?.?
React
Browser
TypeScript
etc.
@oren-l oren-l added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 7, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 7, 2020

I have got the same confusing feedback from @DDDDDanica. @mnajdova maybe we should remove this link from the side bar?

@KaRkY
Copy link
Contributor

KaRkY commented Jul 7, 2020

Instead of redirecting maybe put Deprication Warning with link to Acordion on Expnsion Panel page.

@oliviertassinari
Copy link
Member

I'm closing, let's see if this problem is raised more often.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v4.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 8, 2020
@eljenso
Copy link

eljenso commented Jul 8, 2020

Please change the documentation such that it represents the current stable version of @material-ui.

I was just looking into the Accordion component and was wondering why @material-ui/core does not provide such an export.
Looked at the docs again, and did not see anything wrong with the import.

Had to look into this repository to find out that the component is called ExpansionPanel in the current stable version and the docs are wrong (or already living in the future 😄).

I'm not saying that it is too much to ask from a developer to look into the repository.
I am just thinking that the official docs should reflect the current stable version of the package.

@oliviertassinari
Copy link
Member

@eljenso Update to the latest minor release, you will find the component. Make sure the documentation version you browse is close to the version installed.

@eljenso
Copy link

eljenso commented Jul 8, 2020

@oliviertassinari Thank you for the hint.

I was only looking at CHANGELOG.md and did see any changes to ExpansionPanel outside of v5.
But finally found the release notes of 4.11 which state what you said.

oliviertassinari added a commit that referenced this issue Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation v4.x
Projects
None yet
Development

No branches or pull requests

4 participants