Acceptance Testing

[maitriyogin]

Hi,
first thanks for an awesome implementation!
And keeping upto date so fast, cool.
Anyway, I'm wondering what the best practices are for identifying dom elements for acceptance testing?
I'm using nightwatch but would be the same for protractor, fitness etc ...
I can't seem to find a way of setting ids on the components ? which may not be the best way to go anyway and I'v been moving more to adding html5 test attributes (testId=something) on elements to keep the ids seperate...
I'm having to set a BEM style name on the class attribute contentClassName="login__dialog" which I can then query in my tests
client.expect.element('.login__dialog').to.be.present.before(500);

What is the best practice for this?

Setting a classname feels a bit spooky, not having an id I can understand, but not having a way of setting say a html5 attribute for testing purposes is kind of challenging ...
Look forward to your replies,
Stephen.

[oliviertassinari]

I don't know what is the best way to do fonctionnal testing. However I can expose you how I'm doing it.

As you said, the challenge is regarding selecting elements. To do it I'm adding data-test property to the root of my component.
Then to get ride of them in the production build, I'm using https://github.com/oliviertassinari/babel-plugin-react-remove-properties

[maitriyogin]

sounds interesting, are you just putting that property directly on the MUI React component?
like <FlatButton data-test='appbar__logout’ />
/Stephen.

On 23 Oct 2015, at 15:30, Olivier Tassinari [email protected] wrote:

I don't know what is the best way to do fonctionnal testing. However I can expose you how I'm doing it.

As you said, the challenge is regarding selecting elements. To do it I'm adding data-test property to the root of my component.
Then to get ride of them in the production build, I'm using https://github.com/oliviertassinari/babel-plugin-react-remove-properties https://github.com/oliviertassinari/babel-plugin-react-remove-properties
—
Reply to this email directly or view it on GitHub #1973 (comment).

[oliviertassinari]

Yes, like this.
It may not works for some components. I had to submit a PR for those one. (merged now)

[mbrookes]

See #3330.