Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material-ui-theme-editor Update #17991

Closed
Chris9540 opened this issue Oct 22, 2019 · 9 comments
Closed

material-ui-theme-editor Update #17991

Chris9540 opened this issue Oct 22, 2019 · 9 comments

Comments

@Chris9540
Copy link

hi there iv'e create an updated version of In Your SaaS's material-ui-theme-editor
just wondered if you're interested in it?
https://github.com/Chris9540/material-ui-theme-editor

@mbrookes
Copy link
Member

The "Click here to access it" link links to the IYS version, so it isn't apparent (without reviewing the code) what has been extended.

Also, how had you hoped we might resolve this issue?

@oliviertassinari
Copy link
Member

Side thought: I think that we should, at some point, work on a live theme builder. I have started to collect benchmark sources: https://trello.com/c/m5FHVBnk/1277-theme-builder. Big 👍 for having themes demos outside the Material Design spec.

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 24, 2019

@mbrookes is right, a live demo for this project is critically important.

@Chris9540
Copy link
Author

Chris9540 commented Oct 25, 2019 via email

@oliviertassinari
Copy link
Member

@Chris9540 Nice. I would propose that we link your project in the documentation, alongside create-mui-theme, material-ui-theme-editor, and Material palette generator :). These projects can be useful, at least, until we provide an official theme builder 🎨.

@mbrookes
Copy link
Member

@Chris9540 Great!

It took me a while to realise I had to use the Nav hamburger menu to access the edit functions, so you might like to find a way to make discoverability more easy. (Something like https://github.com/TeamWertarbyte/material-ui-feature-discovery-prompt ?)

@oliviertassinari
Copy link
Member

@mbrookes Agree 👍 for having the side nav always visible.

@oliviertassinari
Copy link
Member

@Chris9540 Do you want to add a link in the documentation?

@oliviertassinari
Copy link
Member

I'm closing as I don't think that we need to keep the issue open, thank you for sharing.

These projects can be useful, at least, until we provide an official theme builder 🎨.

So feel free to add a link in the documentation :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants