-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
material-ui-theme-editor Update #17991
Comments
The "Click here to access it" link links to the IYS version, so it isn't apparent (without reviewing the code) what has been extended. Also, how had you hoped we might resolve this issue? |
Side thought: I think that we should, at some point, work on a live theme builder. I have started to collect benchmark sources: https://trello.com/c/m5FHVBnk/1277-theme-builder. Big 👍 for having themes demos outside the Material Design spec. |
@mbrookes is right, a live demo for this project is critically important. |
The link has been updated. Take a look
…On Thu, 24 Oct 2019, 20:13 Olivier Tassinari, ***@***.***> wrote:
@mbrookes <https://github.com/mbrookes> Is right, a live demo for this is
critically important.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#17991>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZMXXBL56NBD4QUL7SGUJDQQHXXNANCNFSM4JDRZ2RQ>
.
|
@Chris9540 Nice. I would propose that we link your project in the documentation, alongside create-mui-theme, material-ui-theme-editor, and Material palette generator :). These projects can be useful, at least, until we provide an official theme builder 🎨. |
@Chris9540 Great! It took me a while to realise I had to use the Nav hamburger menu to access the edit functions, so you might like to find a way to make discoverability more easy. (Something like https://github.com/TeamWertarbyte/material-ui-feature-discovery-prompt ?) |
@mbrookes Agree 👍 for having the side nav always visible. |
@Chris9540 Do you want to add a link in the documentation? |
I'm closing as I don't think that we need to keep the issue open, thank you for sharing.
So feel free to add a link in the documentation :). |
hi there iv'e create an updated version of In Your SaaS's material-ui-theme-editor
just wondered if you're interested in it?
https://github.com/Chris9540/material-ui-theme-editor
The text was updated successfully, but these errors were encountered: