Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField with outlined variant lose round corner in IE11 #15389

Closed
ShawTim opened this issue Apr 17, 2019 · 12 comments
Closed

TextField with outlined variant lose round corner in IE11 #15389

ShawTim opened this issue Apr 17, 2019 · 12 comments
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)

Comments

@ShawTim
Copy link

ShawTim commented Apr 17, 2019

TextField with outlined variant suppose to have round corners and is working well in other browser like Firefox/Chrome. But in IE11, it lose round corners.

You can check it on https://next.material-ui.com/demos/text-fields/ (sadly, https://material-ui.com/demos/text-fields/ is not accessible by IE11).

Expected Behavior 🤔

This is what i see in Firefox, with beautiful round corners:
image

Current Behavior 😯

This is what i see in IE11, no round corners:
image

Steps to Reproduce 🕹

  1. go to https://next.material-ui.com/demos/text-fields/
  2. compare the Outlined layout in Firefox/Chrome and IE11

Your Environment 🌎

Tech Version
Material-UI v3-9-0, v4-0-0
React
Browser IE11
TypeScript
etc.
@eps1lon
Copy link
Member

eps1lon commented Apr 18, 2019

This is related to border-radius in IE11. Apparently rendering the page in compatbility view should work but that causes other styles to break. At least our docs experience weird jitter.

I don't think we can do much about it without using a pure JS polyfill for border-radius

@eps1lon eps1lon added bug: IE11 component: text field This is the name of the generic UI component, not the React module! labels Apr 18, 2019
@oliviertassinari oliviertassinari added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) bug 🐛 Something doesn't work and removed bug: IE11 labels Apr 18, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 18, 2019

I have noticed this problem when introducing the outlined variant. I don't think that we should solve it.

@eps1lon
Copy link
Member

eps1lon commented Apr 18, 2019

I have noticed this problem when introducing the outlined variant. I don't think that we should solve it.

What other browsers have an issue with border-radius?

@ShawTim
Copy link
Author

ShawTim commented Apr 18, 2019

but i think it's better to be consistent.
if the styles are not consistent across browser, at least it needs to be consistent in IE11.

if it supports in IE11 - then all TextField should have round corners
if it's not supporting in IE11 - then all TextField should not have round corners.

as you can see in the screenshot the "Bare" TextField does already have round corners but not others.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 18, 2019

What other browsers have an issue with border-radius?

@eps1lon I believe it's a IE 11 only issue.

@ShawTim We do our best effort for IE 11. But it can't be at the expense of everybody else. IE 11 market share should soon drop significantly in the next couple of months. I believe that IE 11 has still an important market share because the users can't upgrade to Microsoft Edge. Edge has taken a strong architectural choice that prevented it to be compatible with the older version of Windows. As the Edge team is moving to a Chromium core, this architectural limitation is going away. We are tracking it in #14420.

I was chatting with somebody close to the Chrome team. It's how I have heard about this possible trend. The future will tell us.

@oliviertassinari
Copy link
Member

The provide more context. The first version of the Outlined TextField was using SVG elements. The implementation was later simplified to use a fieldset at the expense of IE 11 border radius. If you are aware of a simpler implementation that can be simple to override and has a limited bundle size impact, we would be happy to solve the problem. Until then, I'm closing.

@synedra-mpe
Copy link

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 17, 2020

@synedra-mpe I fear our support intent for IE 11 isn't meant to be as good as for the other browsers. We have been cutting corners. It's also an incentive for users to end-upgrade their browsers/OS, they will benefit from a better UX.

@synedra-mpe
Copy link

synedra-mpe commented Jun 18, 2020

I would agree, if were not talking about the cardinal and most important ui element of material ui here, the Text filed. Wouldnt be concerned, if some less relevant feature, like a datepicker would not render 100% accurat in ie11.

https://material-ui.com/getting-started/supported-platforms/#browser states,

It also supports Internet Explorer 11.

It would make sense to rewrite this paragraph and point to what is communicated in #15389 (comment).

@oliviertassinari
Copy link
Member

It's a best effort, we assume that our users would want to optimize for >80% of their end-users, not optimize for a minority, as IE 11 is increasingly becoming. For context #14420.

@eps1lon
Copy link
Member

eps1lon commented Jun 18, 2020

It's not like the textfield isn't working. It's only missing the border-radius which is absent from IE11 anyway.

@gsabanov
Copy link

Setting legend to display:inline-block brings back the rounded borders in IE 11, but to get the "notch" to work more work is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

No branches or pull requests

5 participants