[Fade] Fix propTypes not warning on missing child element

mui · Feb 12, 2019 · d10309b · d10309b
1 parent 1ed6682
commit d10309b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/material-ui/src/Fade/Fade.js b/packages/material-ui/src/Fade/Fade.js
@@ -61,7 +61,7 @@ class Fade extends React.Component {
 
     const style = {
       ...styleProp,
-      ...(React.isValidElement(children) ? children.props.style : {}),
+      ...children.props.style,
     };
 
     return (
@@ -87,7 +87,7 @@ Fade.propTypes = {
   /**
    * A single child content element.
    */
-  children: PropTypes.oneOfType([PropTypes.element, PropTypes.func]),
+  children: PropTypes.element.isRequired,
   /**
    * If `true`, the component will transition in.
    */

diff --git a/pages/api/fade.md b/pages/api/fade.md
@@ -21,7 +21,7 @@ The `hidden` prop will be set on the child according to the `in` prop.
 
 | Name | Type | Default | Description |
 |:-----|:-----|:--------|:------------|
-| <span class="prop-name">children</span> | <span class="prop-type">union:&nbsp;element&nbsp;&#124;<br>&nbsp;func<br></span> |   | A single child content element. |
+| <span class="prop-name required">children *</span> | <span class="prop-type">element</span> |   | A single child content element. |
 | <span class="prop-name">in</span> | <span class="prop-type">bool</span> |   | If `true`, the component will transition in. |
 | <span class="prop-name">timeout</span> | <span class="prop-type">union:&nbsp;number&nbsp;&#124;<br>&nbsp;{ enter?: number, exit?: number }<br></span> | <span class="prop-default">{  enter: duration.enteringScreen,  exit: duration.leavingScreen,}</span> | The duration for the transition, in milliseconds. You may specify a single timeout for all transitions, or individually with an object. |