[createSpacing] Narrow return type (#14745)

mui · Mar 5, 2019 · 8304d9d · 8304d9d
1 parent d4425c6
commit 8304d9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/packages/material-ui/src/styles/createSpacing.d.ts b/packages/material-ui/src/styles/createSpacing.d.ts
@@ -1,18 +1,17 @@
 /* tslint:disable:unified-signatures */
 
 export type SpacingArgument = number | string;
-export type SpacingReturnType = number | string;
 
 export interface Spacing {
-  (value1: SpacingArgument): SpacingReturnType;
-  (value1: SpacingArgument, value2: SpacingArgument): SpacingReturnType;
-  (value1: SpacingArgument, value2: SpacingArgument, value3: SpacingArgument): SpacingReturnType;
+  (value1: SpacingArgument): number;
+  (value1: SpacingArgument, value2: SpacingArgument): string;
+  (value1: SpacingArgument, value2: SpacingArgument, value3: SpacingArgument): string;
   (
     value1: SpacingArgument,
     value2: SpacingArgument,
     value3: SpacingArgument,
     value4: SpacingArgument,
-  ): SpacingReturnType;
+  ): string;
 }
 
 export type SpacingOptions = number | Spacing;

diff --git a/packages/material-ui/test/typescript/styles.spec.tsx b/packages/material-ui/test/typescript/styles.spec.tsx
@@ -155,10 +155,10 @@ const theme2 = createMuiTheme({
   },
 });
 
-const t1 = createMuiTheme().spacing(1);
-const t2 = createMuiTheme().spacing(1, 2);
-const t3 = createMuiTheme().spacing(1, 2, 3);
-const t4 = createMuiTheme().spacing(1, 2, 3, 4);
+const t1: number = createMuiTheme().spacing(1);
+const t2: string = createMuiTheme().spacing(1, 2);
+const t3: string = createMuiTheme().spacing(1, 2, 3);
+const t4: string = createMuiTheme().spacing(1, 2, 3, 4);
 // $ExpectError
 const t5 = createMuiTheme().spacing(1, 2, 3, 4, 5);