Fix PR comments

mui · Nov 25, 2024 · 7803c4b · 7803c4b
1 parent fe585a2
commit 7803c4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/docs/data/material/components/slider/slider.md b/docs/data/material/components/slider/slider.md
@@ -103,12 +103,12 @@ Set the `orientation` prop to `"vertical"` to create vertical sliders. The thumb
 {{"demo": "VerticalSlider.js"}}
 
 :::warning
-Chrome versions below 124 implements `aria-orientation` incorrrectly for vertical sliders and exposes them as `'horizontal'` in the accessibility tree. ([Chromium issue #40736841](https://issues.chromium.org/issues/40736841))
+Chrome versions below 124 implements `aria-orientation` incorrectly for vertical sliders and exposes them as `'horizontal'` in the accessibility tree. ([Chromium issue #40736841](https://issues.chromium.org/issues/40736841))
 
 The `-webkit-appearance: slider-vertical` CSS property can be used to correct this for these older versions, with the trade-off of causing a console warning in newer Chrome versions:
 
 ```css
-.MuiSlider-thumb > input {
+.MuiSlider-thumb input {
   -webkit-appearance: slider-vertical;
 }
 ```

diff --git a/packages/mui-material/src/Slider/useSlider.ts b/packages/mui-material/src/Slider/useSlider.ts
@@ -687,12 +687,10 @@ export function useSlider(parameters: UseSliderParameters): UseSliderReturnValue
     };
   };
 
-  const cssWritingMode = React.useMemo(() => {
-    if (orientation === 'vertical') {
-      return isRtl ? 'vertical-rl' : 'vertical-lr';
-    }
-    return undefined;
-  }, [isRtl, orientation]);
+  let cssWritingMode: 'vertical-rl' | 'vertical-lr' | undefined;
+  if (orientation === 'vertical') {
+    cssWritingMode = isRtl ? 'vertical-rl' : 'vertical-lr';
+  }
 
   const getHiddenInputProps = <ExternalProps extends Record<string, unknown> = {}>(
     externalProps: ExternalProps = {} as ExternalProps,