diego review

mui · Mar 12, 2024 · 640c0f6 · 640c0f6
1 parent 57791c4
commit 640c0f6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 25 deletions.
diff --git a/packages/mui-material/src/StepLabel/StepLabel.d.ts b/packages/mui-material/src/StepLabel/StepLabel.d.ts
@@ -23,7 +23,9 @@ export type StepLabelSlotsAndSlotProps = CreateSlotsAndSlotProps<
 
 export interface StepLabelOwnerState extends StepLabelProps {}
 
-export interface StepLabelProps extends StandardProps<React.HTMLAttributes<HTMLDivElement>> {
+export interface StepLabelProps
+  extends StandardProps<React.HTMLAttributes<HTMLDivElement>>,
+    StepLabelSlotsAndSlotProps {
   /**
    * In most cases will simply be a string containing a title for the label.
    */
@@ -57,22 +59,6 @@ export interface StepLabelProps extends StandardProps<React.HTMLAttributes<HTMLD
    * The optional node to display.
    */
   optional?: React.ReactNode;
-  /**
-   * The props used for each slot inside.
-   * @default {}
-   */
-  slotProps?: {
-    /**
-     * Props applied to the label element.
-     * @default {}
-     */
-    label?: React.HTMLProps<HTMLSpanElement>;
-  };
-  /**
-   * The components used for each slot inside.
-   * @default {}
-   */
-  slots?: {};
   /**
    * The component to render in place of the [`StepIcon`](/material-ui/api/step-icon/).
    */
@@ -99,7 +85,7 @@ export type StepLabelClasskey = keyof NonNullable<StepLabelProps['classes']>;
  *
  * - [StepLabel API](https://mui.com/material-ui/api/step-label/)
  */
-declare const StepLabel: ((props: StepLabelProps & StepLabelSlotsAndSlotProps) => JSX.Element) & {
+declare const StepLabel: ((props: StepLabelProps) => JSX.Element) & {
   muiName: string;
 };
 

diff --git a/packages/mui-material/src/StepLabel/StepLabel.js b/packages/mui-material/src/StepLabel/StepLabel.js
@@ -164,7 +164,7 @@ const StepLabel = React.forwardRef(function StepLabel(inProps, ref) {
     },
   };
 
-  const [StepLabelLabelSlot, stepLabelLabelProps] = useSlot('label', {
+  const [LabelSlot, labelProps] = useSlot('label', {
     elementType: StepLabelLabel,
     externalForwardedProps,
     ownerState,
@@ -190,12 +190,9 @@ const StepLabel = React.forwardRef(function StepLabel(inProps, ref) {
       ) : null}
       <StepLabelLabelContainer className={classes.labelContainer} ownerState={ownerState}>
         {children ? (
-          <StepLabelLabelSlot
-            {...stepLabelLabelProps}
-            className={clsx(classes.label, stepLabelLabelProps?.className)}
-          >
+          <LabelSlot {...labelProps} className={clsx(classes.label, labelProps?.className)}>
             {children}
-          </StepLabelLabelSlot>
+          </LabelSlot>
         ) : null}
         {optional}
       </StepLabelLabelContainer>

diff --git a/packages/mui-material/src/StepLabel/StepLabel.test.js b/packages/mui-material/src/StepLabel/StepLabel.test.js
@@ -18,7 +18,6 @@ describe('<StepLabel />', () => {
     render,
     refInstanceof: window.HTMLSpanElement,
     testVariantProps: { error: true },
-    testLegacyComponentsProp: false,
     slots: {
       label: { expectedClassName: classes.label },
     },