Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript typings using TextFieldProps #1469

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 24, 2020

We're trying to run typescript tests while checking libs and this change would unblock mui/material-ui#19375.

I noticed this was recently touched in #1315 but no test was added. As far as I can tell this should fix #1311 as well.

Not familiar with your testing setup for types. If you have some tests for tests I'll add one. Just need to know where.

@dmtrKovalenko
Copy link
Member

I am mostly adding tests by passing random props in our test files. Which are writtern also in typescript so any ts error will fail the test.
But probably we need to have separate tests, at least for integration with the core.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #1469 into v3-x will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v3-x    #1469      +/-   ##
==========================================
+ Coverage   93.42%   93.49%   +0.07%     
==========================================
  Files          55       55              
  Lines        1353     1353              
  Branches      200      210      +10     
==========================================
+ Hits         1264     1265       +1     
+ Misses         70       69       -1     
  Partials       19       19
Impacted Files Coverage Δ
lib/src/_shared/KeyboardDateInput.tsx 100% <100%> (ø) ⬆️
lib/src/_shared/PureDateInput.tsx 82.35% <100%> (ø) ⬆️
lib/src/views/Clock/ClockPointer.tsx 96% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6214e4a...9eac7c0. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit ebf1759 into mui:v3-x Jan 24, 2020
@eps1lon
Copy link
Member Author

eps1lon commented Jan 24, 2020

@eps1lon eps1lon deleted the fix/textfieldprops-typings branch January 24, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants