Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clock number position issue #1327

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Fix clock number position issue #1327

merged 1 commit into from
Sep 25, 2019

Conversation

bndynet
Copy link
Contributor

@bndynet bndynet commented Sep 25, 2019

This PR closes #1321

Description

If overwrite theme spacing as below at https://material-ui.com/customization/spacing/#custom-spacing. The clock number position is not right.

const theme = createMuiTheme({
  spacing: factor => `${0.25 * factor}rem`, // (Bootstrap strategy)
});

Screenshot

image

@vercel vercel bot temporarily deployed to staging September 25, 2019 04:29 Inactive
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #1327 into next will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #1327      +/-   ##
=========================================
- Coverage   93.7%   93.56%   -0.15%     
=========================================
  Files         55       55              
  Lines       1350     1351       +1     
  Branches     199      200       +1     
=========================================
- Hits        1265     1264       -1     
- Misses        67       68       +1     
- Partials      18       19       +1
Impacted Files Coverage Δ
lib/src/views/Clock/ClockNumber.tsx 89.47% <0%> (-4.98%) ⬇️
lib/src/views/Clock/ClockPointer.tsx 92% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d7c42...105be60. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 1db67e6 into mui:next Sep 25, 2019
LorenzHenk pushed a commit to LorenzHenk/material-ui-pickers that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling issue when using a custom spacing function
2 participants