Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyup build config #1309

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Tidyup build config #1309

merged 2 commits into from
Sep 13, 2019

Conversation

TrySound
Copy link
Contributor

  • upgraded babel
  • upgraded rollup
  • fixed material-ui globals
  • replaced babel cli with rollup config with many entries
  • auto resolve named exports
  • skip non existent export warning
  • import correct (esm/cjs) babel helpers
  • error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js

- upgraded babel
- upgraded rollup
- fixed material-ui globals
- replaced babel cli with rollup config with many entries
- auto resolve named exports
- skip non existent export warning
- import correct (esm/cjs) babel helpers
- error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

```
Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js
```
@cypress
Copy link

cypress bot commented Sep 11, 2019



Test summary

50 0 0 0


Run details

Project material-ui-pickers
Status Passed
Commit 707e0dc
Started Sep 11, 2019 7:33 PM
Ended Sep 11, 2019 7:34 PM
Duration 00:48 💡
OS Linux Debian - 8.11
Browser Electron 61

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #1309 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1309      +/-   ##
=========================================
+ Coverage   93.62%   93.7%   +0.07%     
=========================================
  Files          55      55              
  Lines        1350    1350              
  Branches      209     209              
=========================================
+ Hits         1264    1265       +1     
+ Misses         68      67       -1     
  Partials       18      18
Impacted Files Coverage Δ
lib/src/views/Clock/ClockPointer.tsx 96% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddddbd9...707e0dc. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit ad6314b into master Sep 13, 2019
dmtrKovalenko added a commit that referenced this pull request Sep 13, 2019
* Documentation improvements  (#1229)

* [docs] Show DateIOType instead of anys  (#1228)

* Show DateIOType instead of any in prop types tables

* Update patrons list

* Remove unused filter

* Ovveride keyboard datepicker onChange date type

* Update prop-types.json

* Clarify TypeScript instructions for CSS overrides (#1257)

* Fix MuiPickersOverrides import in CSS guide

* Make instructions a little more dummy proof

* Tidyup build config (#1309)

* Tidyup build config

- upgraded babel
- upgraded rollup
- fixed material-ui globals
- replaced babel cli with rollup config with many entries
- auto resolve named exports
- skip non existent export warning
- import correct (esm/cjs) babel helpers
- error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

```
Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js
```

* Remove object-rest-spread
dmtrKovalenko added a commit that referenced this pull request Sep 13, 2019
* Documentation improvements  (#1229)

* [docs] Show DateIOType instead of anys  (#1228)

* Show DateIOType instead of any in prop types tables

* Update patrons list

* Remove unused filter

* Ovveride keyboard datepicker onChange date type

* Update prop-types.json

* Clarify TypeScript instructions for CSS overrides (#1257)

* Fix MuiPickersOverrides import in CSS guide

* Make instructions a little more dummy proof

* Tidyup build config (#1309)

* Tidyup build config

- upgraded babel
- upgraded rollup
- fixed material-ui globals
- replaced babel cli with rollup config with many entries
- auto resolve named exports
- skip non existent export warning
- import correct (esm/cjs) babel helpers
- error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

```
Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js
```

* Remove object-rest-spread
dmtrKovalenko added a commit that referenced this pull request Sep 13, 2019
* Update packages

* [typescript] Fix extending TextField issue

* Master (#1314)

* Documentation improvements  (#1229)

* [docs] Show DateIOType instead of anys  (#1228)

* Show DateIOType instead of any in prop types tables

* Update patrons list

* Remove unused filter

* Ovveride keyboard datepicker onChange date type

* Update prop-types.json

* Clarify TypeScript instructions for CSS overrides (#1257)

* Fix MuiPickersOverrides import in CSS guide

* Make instructions a little more dummy proof

* Tidyup build config (#1309)

* Tidyup build config

- upgraded babel
- upgraded rollup
- fixed material-ui globals
- replaced babel cli with rollup config with many entries
- auto resolve named exports
- skip non existent export warning
- import correct (esm/cjs) babel helpers
- error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

```
Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js
```

* Remove object-rest-spread

* Update packages

* Fix typescript compilation errros
@TrySound TrySound deleted the tidyup-config branch September 15, 2019 12:55
LorenzHenk pushed a commit to LorenzHenk/material-ui-pickers that referenced this pull request Nov 11, 2019
* Update packages

* [typescript] Fix extending TextField issue

* Master (mui#1314)

* Documentation improvements  (mui#1229)

* [docs] Show DateIOType instead of anys  (mui#1228)

* Show DateIOType instead of any in prop types tables

* Update patrons list

* Remove unused filter

* Ovveride keyboard datepicker onChange date type

* Update prop-types.json

* Clarify TypeScript instructions for CSS overrides (mui#1257)

* Fix MuiPickersOverrides import in CSS guide

* Make instructions a little more dummy proof

* Tidyup build config (mui#1309)

* Tidyup build config

- upgraded babel
- upgraded rollup
- fixed material-ui globals
- replaced babel cli with rollup config with many entries
- auto resolve named exports
- skip non existent export warning
- import correct (esm/cjs) babel helpers
- error when material-ui global is not provided

Here's generated build/esm/. Treeshaking should work fine.

```
Calendar-b9ae6101.js
Calendar.js
Clock-3486e4fb.js
Clock.js
ClockView.js
DatePicker.js
DateTimePicker.js
Day.js
Picker-429246aa.js
Picker.js
TimePicker.js
TimePickerToolbar-e568e280.js
Wrapper-12538b96.js
index.js
makePickerWithState-8a1dec7e.js
useUtils-7fbeb79a.js
```

* Remove object-rest-spread

* Update packages

* Fix typescript compilation errros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants