Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useScrollLock] Avoid scrollbar layout shift issues #604

Merged
merged 31 commits into from
Sep 17, 2024
Merged

[useScrollLock] Avoid scrollbar layout shift issues #604

merged 31 commits into from
Sep 17, 2024

Commits on Sep 12, 2024

  1. [useLockScroll] Avoid scrollbar issues

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    39e9ef3 View commit details
    Browse the repository at this point in the history

  2. window.scrollTo?. for jsdom

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    353ca90 View commit details
    Browse the repository at this point in the history

  3. Check for property

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f55a1ea View commit details
    Browse the repository at this point in the history

  4. Check for native scrollTo

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f9c5894 View commit details
    Browse the repository at this point in the history

  5. Handle original styles

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    de27905 View commit details
    Browse the repository at this point in the history

  6. Handle scrollbar-gutter: stable

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    51fd682 View commit details
    Browse the repository at this point in the history

  7. Improve nested locking

    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9e9c74a View commit details
    Browse the repository at this point in the history

  8. Apply to body 

    When the body has an overflow-y: scroll style, layout shift would still occur
    @atomiks
    atomiks committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8d23647 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Playground + resize + iOS fixes

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    25438b6 View commit details
    Browse the repository at this point in the history

  2. Move scrollbarWidth into function

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9392376 View commit details
    Browse the repository at this point in the history

  3. Comments

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c74dc6b View commit details
    Browse the repository at this point in the history

  4. typo

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d27e797 View commit details
    Browse the repository at this point in the history

  5. Improve experiment

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    acefccd View commit details
    Browse the repository at this point in the history

  6. Use react-aria for iOS

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4ccd89b View commit details
    Browse the repository at this point in the history

  7. Simplify lockIds

    @atomiks
    atomiks committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2a21a48 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Rewrite implementation

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e3f9bf7 View commit details
    Browse the repository at this point in the history

  2. Remove body style

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    66abfac View commit details
    Browse the repository at this point in the history

  3. Remove id

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    01fec79 View commit details
    Browse the repository at this point in the history

  4. Handle constant overflow

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bc8ecc9 View commit details
    Browse the repository at this point in the history

  5. Handle dual scrollbars

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bbf5374 View commit details
    Browse the repository at this point in the history

  6. Update docs/app/experiments/scroll-lock.tsx 

    Co-authored-by: Olivier Tassinari <[email protected]>
Signed-off-by: atomiks <[email protected]>
    @atomiks @oliviertassinari
    atomiks and oliviertassinari authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    512c5d0 View commit details
    Browse the repository at this point in the history

  7. getComputedStyle

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    88e0e4f View commit details
    Browse the repository at this point in the history

  8. perf

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a7fbacf View commit details
    Browse the repository at this point in the history

  9. Remove return

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    87444f8 View commit details
    Browse the repository at this point in the history

  10. Conditional fixed styles

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    70bbdfa View commit details
    Browse the repository at this point in the history

  11. Assign vars earlier

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8c8adc2 View commit details
    Browse the repository at this point in the history

  12. Add scrollable x check

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    80ec0c1 View commit details
    Browse the repository at this point in the history

  13. Handle body overflow

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    56ca8b9 View commit details
    Browse the repository at this point in the history

  14. Handle body overflow

    @atomiks
    atomiks committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2458dc0 View commit details
    Browse the repository at this point in the history

  15. Update packages/mui-base/src/utils/useScrollLock.ts 

    Co-authored-by: Vlad Moroz <[email protected]>
Signed-off-by: atomiks <[email protected]>
    @atomiks @vladmoroz
    atomiks and vladmoroz authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d8715dd View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Add iOS implementation

    @atomiks
    atomiks committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a9d020e View commit details
    Browse the repository at this point in the history