-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Add arrow
prop
#18323
[Tooltip] Add arrow
prop
#18323
Conversation
@material-ui/core: parsed: +0.37% , gzip: +0.31% Details of bundle changes.Comparing: 9eb38da...f8c03f6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start
@goleary I'm not sure that we need a visual test for this feature. If we want to add one, I would recommend that we start an effort to clean up our visual tests, I suspect we have too many, that many aren't useful. The Argos-ci step starts to feel slow. But I doubt it's very important. It has been a long time since they were really useful. At least, since we have stopped heavy UI refactoring (minors). |
409dd43
to
1740df7
Compare
1740df7
to
f8c03f6
Compare
@goleary Thank you! |
Adding a prop to the Tooltip component so that users don't have to copy and paste code from docs to get an arrow (as it's a common case). Originally discussed here:
I made
arrowGenerator
a util function so that it can be used to create other types of tooltips (like the bootstrap example in the docs).I also updated the docs to give an example of how to use this.
potential issues:
export default function arrowGenerator(color: any): any;
Closes #18243