Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] make arrow a prop (boolean) #18243

Closed
1 task done
goleary opened this issue Nov 7, 2019 · 7 comments · Fixed by #18323
Closed
1 task done

[Tooltip] make arrow a prop (boolean) #18243

goleary opened this issue Nov 7, 2019 · 7 comments · Fixed by #18323
Labels
component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@goleary
Copy link
Contributor

goleary commented Nov 7, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

It would be awesome if arrow was just a prop that could be passed to the Tooltip component to avoid having to copy and paste a bunch of code from the example into my project. It would accept true or false (default false) and create an arrow for the tooltip.

Examples 🌈

Motivation 🔦

There are clearly a good number of people using the arrow on their tooltips from this library. Why not bake it into the library to cut down on the need to copy and paste code from the example docs?

@oliviertassinari oliviertassinari added component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request labels Nov 7, 2019
@oliviertassinari
Copy link
Member

@goleary Great idea 👍

@oliviertassinari
Copy link
Member

Do you want to give it a try :)?

@goleary
Copy link
Contributor Author

goleary commented Nov 7, 2019

Sure, I will give it a shot.

@goleary
Copy link
Contributor Author

goleary commented Nov 7, 2019

@oliviertassinari
running into a small issue while trying to get setup:
image

Do you have a slack or some other method I can use for getting in touch other than polluting this issue's comments section?

@oliviertassinari
Copy link
Member

@goleary Gitter

@Vitao18
Copy link
Contributor

Vitao18 commented Nov 10, 2019

Hey, do you want some help on this issue?

@goleary
Copy link
Contributor Author

goleary commented Nov 11, 2019

@Vitao18 I think I've figured out my issues so I'm good for now. I'll let you know if I run into any more problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants