-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid] Use a unitless spacing API #14099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
oliviertassinari
force-pushed
the
update-grid
branch
from
January 6, 2019 12:37
80b60b8
to
1ace890
Compare
oliviertassinari
changed the title
[Grid] Apply theme.spacing.unit to grid spacing
[Grid] Use a unitless spacing API
Jan 6, 2019
oliviertassinari
force-pushed
the
update-grid
branch
from
January 6, 2019 12:44
1ace890
to
413d5b0
Compare
joshwooding
force-pushed
the
update-grid
branch
from
January 14, 2019 00:24
413d5b0
to
e953b82
Compare
eps1lon
previously requested changes
Jan 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the visual differences intended? https://www.argos-ci.com/mui-org/material-ui/builds/40261
oliviertassinari
force-pushed
the
update-grid
branch
3 times, most recently
from
February 6, 2019 20:10
85a40b4
to
f7b5dcb
Compare
oliviertassinari
force-pushed
the
update-grid
branch
3 times, most recently
from
February 6, 2019 22:32
88e8203
to
9113d95
Compare
oliviertassinari
approved these changes
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
joshwooding
reviewed
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
joshwooding
reviewed
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
joshwooding
reviewed
Feb 6, 2019
joshwooding
reviewed
Feb 6, 2019
docs/src/pages/getting-started/page-layout-examples/checkout/Checkout.js
Show resolved
Hide resolved
joshwooding
reviewed
Feb 6, 2019
docs/src/pages/getting-started/page-layout-examples/checkout/Checkout.js
Show resolved
Hide resolved
joshwooding
reviewed
Feb 6, 2019
joshwooding
reviewed
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
mbrookes
reviewed
Feb 6, 2019
oliviertassinari
force-pushed
the
update-grid
branch
2 times, most recently
from
February 7, 2019 10:34
34ae605
to
d5a7a81
Compare
oliviertassinari
force-pushed
the
update-grid
branch
5 times, most recently
from
February 7, 2019 18:48
3e685db
to
0823684
Compare
oliviertassinari
force-pushed
the
update-grid
branch
from
February 7, 2019 18:56
0823684
to
9604acf
Compare
56 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion about this PR here.
Closes #12925
Closes #13967
Closes #14280
Breaking change
In order to support arbitrary spacing values and to remove the need to mentally county by 8, we are changing the spacing API:
Going forward, you can use the theme to implement a custom Grid spacing transformation function: https://material-ui.com/system/spacing/#transformation.
Deprecation
theme.spacing.unit
usage is deprecated, you can use the new API:Tip: you can provide more than 1 argument: theme.spacing(1, 2) // = '8px 16px'