Update material-ui to version 4 #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2019 19:28
a higher order component for styling so instead we find an ancestor
Lily418
changed the title
eneufeld
reviewed
Jun 6, 2019
| @@ -79,7 +79,7 @@ export const MaterialListWithDetailRenderer = | |||
| addItem={addItem} | |||
| createDefault={handleCreateDefaultValue} | |||
| /> | |||
| <Grid container direction='row' spacing={16}> | |||
| <Grid container direction='row' spacing={10}> | |||
There was a problem hiding this comment.
If I understand the documentation from https://material-ui.com/guides/migration-v3/#layout correctly, then the old 16 should be a 2 now?
There was a problem hiding this comment.
Ah that makes sense, this is the relevant PR.
mui/material-ui#14099
Will update that now
|
@eneufeld have updated the spacing 🛰 |
eneufeld
reviewed
Jun 6, 2019
| @@ -72,7 +72,7 @@ export const MaterialLayoutRenderer = ({ | |||
| <Grid | |||
| container | |||
| direction={direction} | |||
| spacing={direction === 'row' ? 16 : 0} | |||
| spacing={direction === 'row' ? 10 : 0} | |||
There was a problem hiding this comment.
Very spooky 👻
Have updated!
There was a problem hiding this comment.
Great, my German to English translation failed me ;-)
There was a problem hiding this comment.
Haha 😂 not at all! Apologies I was making a bad joke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use material-ui version 4 so I can use the new version of ThemeProvider and ServerStyleSheets with next
The type of GridSpacing has been updated
https://github.com/mui-org/material-ui/blob/89687f38cae750650555772ba4d821c9084d8dfc/packages/material-ui/src/Grid/Grid.d.ts
and ExpansionPanelSummary is now wrapped in a higher order styling component so I updated the test to find an the ancestor ExpandPanelRenderer