-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional wakatime fields #702
Conversation
Thanks, but what's the point of including these fields without actually populating them with values? |
You're right, sorry for not having thought about this a little more. May I ask how you're using these fields, since they're gonna be included in any summary and will not be shown anywhere on the UI? Also two more remarks regarding your changes:
|
Will add a hint to the release notes to manually run the following commands before the upgrade (apparently, they don't require locking the table, so can be done at runtime): # MySQL
alter table heartbeats
add `lines` bigint,
add `line_no` bigint,
add `cursor_pos` bigint,
add `line_deletions` bigint,
add `line_additions` bigint,
add `project_root_count` bigint,
algorithm = inplace;
# Postgres
alter table heartbeats
add "lines" bigint,
add "line_no" bigint,
add "cursor_pos" bigint,
add "line_deletions" bigint,
add "line_additions" bigint,
add "project_root_count" bigint;
# SQLite
alter table heartbeats add column lines integer;
alter table heartbeats add column line_no integer;
alter table heartbeats add column cursor_pos integer;
alter table heartbeats add column line_deletions integer;
alter table heartbeats add column line_additions integer;
alter table heartbeats add column project_root_count integer; |
@muety Thanks for pointing out the database migration part, I didn't realize it would take so long in a large dataset. I didn't see this problem because my dataset is not as large as yours, and there are only 3k heartbeats in the table. |
Your commits are all attributed to that user, because your local Git config uses |
@ouuan Hahahaha (laughing at myself), I knew it, again, I made such a stupid mistake... Thank you for telling me this. |
Wakapi is a very useful tool, I have been using it to record my work time. Recently I found that Wakatime has some very useful fields that are very helpful for code analysis, but these fields are not recorded in Wakapi. This change is to add these fields in.
These fields are
for all wakatime fields, please refer to https://wakatime.com/developers#heartbeats