Remove circular dependency when logging configuration loading error #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689
When the configuration fails to load properly, an error gets logged using
Log()
. This logger requires the configuration to be loaded properly to function. CallingLog().fatal
when a configuration loading error occurs causes a panic which obstructs the configuration error and confuses users.By downgrading to use the built in
log
package when handling this error, we can get some pretty valuable info on why the configuration has failed to load.Before:
After