Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RSS extensions and a little testing #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drewstinnett
Copy link

Great project! Wanted to submit this for your consideration, adds a couple things:

  • Adds 'Extensions' to each RSSEntry. This will allow folks to add non-standard stuff to their templates, if desired. Personal use case for this is using some fields from the Letterboxd RSS feed, that are not standard. Instead of creating a Letterboxd specific data source, figured this would be more flexible
  • Adds a couple little tests to make sure the RSS Extensions are working. Happy to change these up to whatever sort of test you prefer

Thanks for the cool project!

@muesli
Copy link
Owner

muesli commented Nov 16, 2022

Thanks for the kind words and apologies I haven't reviewed this yet, but I guess I have some reading up to do on RSS extensions first 😄

@muesli muesli added the enhancement New feature or request label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants