Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repo add to set authentication for private repository #370

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Bao0ne
Copy link
Contributor

@Bao0ne Bao0ne commented Dec 5, 2024

Hi! Luet can access private repository by manually editing configuration files.I hope repo add can directly configure the authentication.

Copy link
Contributor

@jimmykarily jimmykarily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be better if we read the docker authentication from the regular docker config (e.g. Using Load and Dir) but I can't decide if we gain anything by that or not. Let's do it this way for now.

Just a small nit, the rest looks good.

cmd/repo/add.go Outdated Show resolved Hide resolved
cmd/repo/add.go Outdated Show resolved Hide resolved
@Bao0ne Bao0ne force-pushed the auth branch 2 times, most recently from 9bc33f9 to d783dcf Compare December 17, 2024 08:28
@mudler
Copy link
Owner

mudler commented Dec 17, 2024

Thank you!

@mudler mudler merged commit e310510 into mudler:master Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants