Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDA-528] Contacts - edit - save to phone #3

Merged
merged 8 commits into from
Nov 30, 2020
Merged

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Nov 26, 2020

Jira: [PDA-528]

Description

⚠️ Warning, the editing doesn't work well with the device because of the API in response return an error with 500 code. This is to check after fix 👉 https://appnroll.atlassian.net/browse/EGD-4519.

However, You need to believe me that the first request was a successful 🙈

PR includes edites, like (screenshots atached):

  • default editting (a form)
  • blocking by action/ from the form
  • unblocking by action/ from the form
Screenshots

Errors handling below

default editting (a form)
Zrzut ekranu 2020-11-26 o 07 22 19 Zrzut ekranu 2020-11-26 o 07 19 44 5 Zrzut ekranu 2020-11-26 o 07 22 24 Zrzut ekranu 2020-11-26 o 07 22 27
blocking by action
Zrzut ekranu 2020-11-26 o 07 18 32 Zrzut ekranu 2020-11-26 o 07 18 35 Zrzut ekranu 2020-11-26 o 07 19 44 8 Zrzut ekranu 2020-11-26 o 07 20 08
blocking from the form
Zrzut ekranu 2020-11-26 o 07 21 42 Zrzut ekranu 2020-11-26 o 07 21 47 Zrzut ekranu 2020-11-26 o 07 19 44 6 Zrzut ekranu 2020-11-26 o 07 21 50
unblocking from the form
Zrzut ekranu 2020-11-26 o 07 20 56 Zrzut ekranu 2020-11-26 o 07 19 44 7 Zrzut ekranu 2020-11-26 o 07 21 01
Error - default editting (a form)
Zrzut ekranu 2020-11-26 o 07 16 11 Zrzut ekranu 2020-11-26 o 07 16 13 Zrzut ekranu 2020-11-26 o 07 16 23 Zrzut ekranu 2020-11-26 o 07 16 27 Zrzut ekranu 2020-11-26 o 07 16 29
Error - blocking by action
Zrzut ekranu 2020-11-26 o 07 14 49 Zrzut ekranu 2020-11-26 o 07 14 52 Zrzut ekranu 2020-11-26 o 07 14 54 Zrzut ekranu 2020-11-26 o 07 14 59 Zrzut ekranu 2020-11-26 o 07 15 01
Error - blocking from the form
Zrzut ekranu 2020-11-26 o 07 15 27 Zrzut ekranu 2020-11-26 o 07 15 34 Zrzut ekranu 2020-11-26 o 07 15 37

Self check

  • Self CR'd
  • Tests included
  • Description and screenshots attached

PR Status

  • Code Review
  • Quality Assurance

Blockers

Deploy Notes

@dkarski dkarski self-assigned this Nov 26, 2020
@dkarski dkarski marked this pull request as ready for review November 26, 2020 07:32
@dkarski dkarski requested a review from mkurczewski November 27, 2020 06:04
@dkarski dkarski merged commit d985040 into master Nov 30, 2020
@dkarski dkarski deleted the PDA-528-contact-edit branch November 30, 2020 10:46
@dkarski dkarski restored the PDA-528-contact-edit branch November 30, 2020 10:46
@dkarski dkarski deleted the PDA-528-contact-edit branch November 30, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants