Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-3171 [API Device][Kompakt] Contacts - viewing #2258

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

CP-3171 [API Device][Kompakt] Contacts - viewing #2258

wants to merge 4 commits into from

Conversation

robertmudi
Copy link
Contributor

@robertmudi robertmudi commented Dec 20, 2024 •
edited by jira bot
Loading

…enario, second for actual contacts viewing

JIRA Reference: CP-3171

📝 Description ️

  • contacts viewing test
  • empty contacts viewing test

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

dkarski
dkarski reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@dkarski dkarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the PR be open? Set it to draft if still in progress. 🙏

apps/mudita-center-e2e/src/specs/overview/kompakt-contacts-viewing-empty.ts Outdated Show resolved Hide resolved
apps/mudita-center-e2e/src/specs/overview/kompakt-contacts-viewing.ts Show resolved Hide resolved
@robertmudi robertmudi marked this pull request as draft December 21, 2024 14:30
@robertmudi robertmudi changed the title CP-3171 first commit, added two test files, one for empty contacts sc… CP-3171 [API Device][Kompakt] Contacts - viewing Dec 21, 2024
@robertmudi robertmudi marked this pull request as ready for review December 21, 2024 16:38
@robertmudi robertmudi requested a review from dkarski December 21, 2024 16:38
@robertmudi robertmudi requested review from milenaniebrzydowska00 and removed request for mkurczewski and MateuszMudita December 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkowalczyk87 lkowalczyk87 Awaiting requested review from lkowalczyk87

@dkarski dkarski Awaiting requested review from dkarski

@milenaniebrzydowska00 milenaniebrzydowska00 Awaiting requested review from milenaniebrzydowska00

At least 1 approving review is required to merge this pull request.

Assignees

@robertmudi robertmudi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmudi @dkarski