Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E][Home Page] MC Force Update - Error handling #2039

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[E2E][Home Page] MC Force Update - Error handling #2039

merged 2 commits into from
Aug 23, 2024

Conversation

patrycja-paczkowska
Copy link
Collaborator

@patrycja-paczkowska patrycja-paczkowska commented Aug 22, 2024 •
edited by jira bot
Loading

JIRA Reference: CP-2924

📝 Description ️

  • Added the test that checks whether the modal informing about an error is shown in case the update package downloading fails.

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

tomaszmaleckimudita
tomaszmaleckimudita approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@tomaszmaleckimudita tomaszmaleckimudita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@tomaszmaleckimudita tomaszmaleckimudita enabled auto-merge (squash) August 23, 2024 06:10
@tomaszmaleckimudita tomaszmaleckimudita merged commit 14a55ed into develop Aug 23, 2024
6 checks passed
@tomaszmaleckimudita tomaszmaleckimudita deleted the CP-2924 branch August 23, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszmaleckimudita tomaszmaleckimudita tomaszmaleckimudita approved these changes

@robertmudi robertmudi Awaiting requested review from robertmudi

Assignees

@patrycja-paczkowska patrycja-paczkowska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrycja-paczkowska @tomaszmaleckimudita