Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP-2898] Split Device Manager into Multiple Modules #1927

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[CP-2898] Split Device Manager into Multiple Modules #1927

merged 2 commits into from
Jun 18, 2024

Conversation

dkarski
Copy link
Member

@dkarski dkarski commented Jun 16, 2024 •
edited
Loading

JIRA Reference: CP-2898]

📝 Description ️

Warning:

This PR was created for easier review. Checks may fail; conflicts will be resolved in the final PR. Review comments will be implemented in the main PR #1921.

Split DeviceManager into device-protocol, core-device modules to separate serialport communication handling and Core device list management.

💪 Checklist before requesting a review - nice to have

  • getState function in async thunk actions is correctly typed
  • redux selectors are used in components / prop drilling is reduce

❗ Checklist before merging a pull request

  • change went through the QA process
  • translations are updated in dedicated application
  • CHANGELOG.md is updated

@dkarski dkarski merged commit 84279e2 into CP-2898 Jun 18, 2024
2 of 7 checks passed
@dkarski dkarski deleted the CP-2898-device-manager-splitted branch June 18, 2024 10:06
lkowalczyk87 pushed a commit that referenced this pull request Aug 7, 2024
@dkarski @lkowalczyk87
[CP-2898] Split Device Manager into Multiple Modules (#1927)
6210b37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkowalczyk87 lkowalczyk87 lkowalczyk87 approved these changes

@MateuszMudita MateuszMudita Awaiting requested review from MateuszMudita

@mkurczewski mkurczewski Awaiting requested review from mkurczewski

Assignees

@dkarski dkarski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarski @lkowalczyk87