Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up GitHub Actions #103

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Tidy up GitHub Actions #103

merged 1 commit into from
Sep 21, 2023

Conversation

mudge
Copy link
Owner

@mudge mudge commented Sep 20, 2023

Try to speed up builds by reducing duplication (no longer testing the Rake extension task but only testing the gems).

@mudge mudge force-pushed the github-actions-cleanup branch from 309562e to ac5e7cf Compare September 20, 2023 19:15
@mudge mudge force-pushed the github-actions-cleanup branch from ac5e7cf to f73f384 Compare September 21, 2023 07:57
@mudge mudge marked this pull request as ready for review September 21, 2023 11:15
@mudge mudge force-pushed the github-actions-cleanup branch 2 times, most recently from 3b52dbe to 03069de Compare September 21, 2023 12:07
Try to speed up builds by reducing duplication (no longer testing the
Rake extension task but only testing the gems).
@mudge mudge force-pushed the github-actions-cleanup branch from 03069de to a9b01b8 Compare September 21, 2023 12:28
@mudge
Copy link
Owner Author

mudge commented Sep 21, 2023

@stanhu this shaves a significant amount of time from a build down (down from over 30 minutes in some cases to ~15 minutes): are you happy we're not losing any important coverage by testing installing the gem (with and without --enable-system-libraries) rather than testing rake compile spec directly?

@stanhu
Copy link
Collaborator

stanhu commented Sep 21, 2023

are you happy we're not losing any important coverage by testing installing the gem (with and without --enable-system-libraries) rather than testing rake compile spec directly?

Yes, that sounds good.

@stanhu stanhu merged commit 23fab86 into main Sep 21, 2023
@mudge mudge deleted the github-actions-cleanup branch May 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants