Add error handling to getSeekableBlob #515
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
getSeekableBlob
had any type of error with the fileReader, or with EBML decoding, the error was uncaught and would never proceed to calling the callback.Now, if it encounters an error, the error is caught and the callback is called with a null result
callback(null)
, allowing the developer's code to respond to the failure instead of halting execution. For example:Alternatively, making this a Promise and calling
reject(error)
could be useful, but I felt was out of scope.