Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from nose to pytest #198

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Migrate from nose to pytest #198

merged 8 commits into from
Aug 8, 2023

Conversation

udim
Copy link
Contributor

@udim udim commented Aug 6, 2023

I believe this is done since there are no more warnings from pytest about deprecated nose compatibility features.

I tested locally in the WebHDFS variant (according to the skipped test count, which was 4). I couldn't figure out how to test using the HTTPFS variant.

Fixes #190

Edit:
There are 4 additional tests being run now, due to the added pandas dependency: 3 in test_ext_dataframe.py and 1 in dataframe-example.py. There are also 4 additional tests that are being skipped in pytest, but were annotated @nottest in nose.

@udim udim changed the title Migrate to testing on pytest Migrate from nose to pytest Aug 6, 2023
@mtth
Copy link
Owner

mtth commented Aug 8, 2023

This is great - thanks @udim!

@mtth mtth merged commit 7c65ae6 into mtth:master Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nose should be replaced with nose2 or pyyest
2 participants