-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improvements to the filters + some ideas #252
Comments
Thanks for the suggestions :)
On the other screen, there's a "show deselected games" toggle, which is remembered between sessions. There are also similar toggles for unchanged and unscanned games. I imagined these as a subset of the filter functionality that would be more useful to keep between sessions, whereas we reset the filters since some combinations are only briefly useful (like "only show me disabled games that have no duplicates"). Beyond those three toggles on the other screen, are there other filter settings/combinations that you'd like to be able to persist?
I don't mind adding that. Just curious, would you still like this even if the filter isn't retained between sessions? I'm wondering how often you might need to clear the filter within a single session.
Agreed, this could use some better styling 👍 |
I should've been more observant. I can see that the Other tab's options are tied to whether some of the drop-down filters are even visible. My first impression is that I'm not too fond of this approach, but I can see why you would've thought to tuck these options away. There are benefits, such as not necessarily even needing to open the filter to have some items always hidden, and that the option applies to both mode tabs, but I don't know if saving the vertical height taken by the filter is a good reason alone for having these options elsewhere (rather than a persistent filter). Those options you point out don't necessarily negate a reason for the filter to function as I suggest. I could get used to it as it is, but my thinking was that having it all controlled via the tab you're on would be better since the visible state of the list is always reflected by the sticky filter at the top. I toggle the visibility of de-/selected items often enough that always going to another tab feels a bit clunky. if the drop-downs at minimum remembered their last value (not necessarily if the drop-down is enabled or not, just its selected value), then opening the filter and clicking the checkbox would still be quicker than three clicks going to the Other tab and back. I guess I just prefer my approach, but it's kind of nitpicking at this stage since the end goal functionality is already implemented. To summarise:
Can't think of any at this time.
There's a bit of free space to the right of the drop-downs even at minimum window width, and maybe it's still worth it in a single session to save on some clicks, e.g. when wanting to clear the checkboxes just to set a single one or something. Other feedback:
|
I've made a few adjustments here:
For now, I think I'd rather not persist the filters or separate the title filter. I have some thoughts for #201 and #260 that may affect that behavior.
|
Nice touches. Appreciated! |
What's your idea?
I think it would be useful if the filter states for the Backup/Restore Modes were remembered across each session of Ludusavi:
I usually don't care about disabled games and so I hide them when things are cluttered. I must first enable the filter, then change the drop-down menu from Disabled to Enabled, and finally click its checkbox. If the filter and its drop-down menu states were remembered, there'd be a lot of flexibility: Perhaps the filter is enabled but the checkbox is empty (just click the checkbox), or perhaps the checkbox is filled, but the whole filter isn't enabled (just click the filter button) -- both cases assume the drop-down box's value of Enabled has been remembered from the previous session.
In addition to remembering states:
Remembering of state and a way to clear the filters seem like good ideas. Maybe the decoupling of the search bar and the filter leads to having to rework too many little things when the filter remaining open across sessions is just a simple solution.
As for when both the filter and settings rows of options are shown, something could be done to make each group of rows more distinct from one another:
For example, if the backup settings options (which are always the middle set of rows) had a light grey background to them, it'd be enough of a visual distinction to break up all three sections, e.g.:
Thanks!
The text was updated successfully, but these errors were encountered: