Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(verifyMeasurement): add marginOfErrorUnder & standardDeviationUnder #3

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

thomaschaplin
Copy link
Contributor

This PR adds the ability to run checks against marginOfErrorUnder & standardDeviationUnder.

@thomaschaplin
Copy link
Contributor Author

@mtkennerly I've added some more functionality, I hope these changes are okay? Let me know what you think!

Copy link
Owner

@mtkennerly mtkennerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mtkennerly mtkennerly merged commit 12396d6 into mtkennerly:master Feb 5, 2021
@mtkennerly mtkennerly added this to the v0.4.0 milestone Feb 5, 2021
@mtkennerly mtkennerly added the enhancement New feature or request label Feb 5, 2021
@thomaschaplin
Copy link
Contributor Author

Looks good to me 👍

Thank you 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants