Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(jest): rename keepState to keepStateAtEnd #2

Merged
merged 1 commit into from
Feb 4, 2021
Merged

test(jest): rename keepState to keepStateAtEnd #2

merged 1 commit into from
Feb 4, 2021

Conversation

thomaschaplin
Copy link
Contributor

To begin, I'd like to say thank you @mtkennerly for building this tool, it's a great piece of work!

This pull request implements the changes found in #1 but with the recommended naming changes from keepState to keepStateAtEnd. I made a new PR as I didn't have permission to edit the existing PR which has these changes.

@mtkennerly
Copy link
Owner

mtkennerly commented Feb 4, 2021

Thanks for the PR and the kind words 👍 I'll get a new release out soon with this addition.

@mtkennerly mtkennerly merged commit 6476504 into mtkennerly:master Feb 4, 2021
@thomaschaplin
Copy link
Contributor Author

Thank you for merging this in @mtkennerly! Yes please, if you could create a new release I'd be very grateful 👍🏼

@thomaschaplin
Copy link
Contributor Author

Hey @mtkennerly do you know when you might get round to releasing these changes? 🙏🏼

@mtkennerly
Copy link
Owner

Should be within the next 12 hours, after I'm done with work :)

@mtkennerly mtkennerly added this to the v0.4.0 milestone Feb 5, 2021
@mtkennerly mtkennerly added the enhancement New feature or request label Feb 5, 2021
@mtkennerly
Copy link
Owner

v0.4.0 is now available with the changes from both of your PRs :D

@thomaschaplin
Copy link
Contributor Author

v0.4.0 is now available with the changes from both of your PRs :D

Awesome, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants