Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Optional[]
to type hints for parameters that can takeNone
. This is useful when running mypy on code consuming Dunami as a library. Otherwise you get type errors from mypy when passingNone
as an argument to these functions.I also updated the
.pre-commit-config.yaml
to run mypy with the--no-implicit-optional
flag to catch parameters that should be marked asOptional
in the future.Thank you for the very helpful library! 🙏🏻