Issue 7821: check multi subtypes card helper function #7833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to Issue #7821
Description of changes
Methodology
(or (has-subtype? card subtype1) (has-subtype? card subtype2))
with `(has-any-subtype? card [subtype1 subtype 2])Adept
,Savant
, other cards that usebreak-multiple-subroutines
will not use this function because they include subtype quantity and therefore splitting the logic into two parts is the most appropriate implementationTesting
lein test
yields same result as currentmaster
stateNext Steps and considerations
has-all-subtypes?
is added but not used except for in tests, should it just be commented out?