New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up set aside #7800

Merged

NoahTheDuke merged 3 commits into mtgred:master from NBKelly:clean-up-set-aside

Oct 8, 2024

Collaborator

NBKelly commented Oct 8, 2024

Makes it so that:

Setting cards aside returns you those cards, instead of requiring you to query again to get them
at the end of your turn, we clear out all the info for set-aside cards that are no longer set-aside (it's a tiny amount - only cids and the eid number, but since every card you draw passes through the set-aside zone, I feel like it could add up).
And I cleaned up a couple of uses of set-aside

NBKelly added 3 commits

October 9, 2024 10:16


          setting cards aside returns the results from move, can clean out stal…

24d469c

…e eids


          clean out set aside at turn end

71a0516


          simplification

NoahTheDuke merged commit 6a080a9 into mtgred:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet