Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move article to vignettes top-level + build ignore it #37

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 21, 2024

About your other question in #36 (comment)

You can now just add the file to the pkgdown/assets directory and it will be available for download on the website.

See what I did in gt for example.

https://gt.rstudio.com/gt-latex.pdf stored in https://github.com/rstudio/gt/tree/master/pkgdown/assets

@mtennekes mtennekes merged commit ad964fc into mtennekes:main Oct 21, 2024
1 check passed
@olivroy
Copy link
Contributor Author

olivroy commented Oct 21, 2024

Still not working.. Honestly, can't tell what is going on..

Might as well just keep 2 copies of images..

@mtennekes
Copy link
Owner

For me it does seem to work :-) Maybe you'll need to clean the browser cache?

@olivroy
Copy link
Contributor Author

olivroy commented Oct 21, 2024

OH! Nice Awesome

@mtennekes
Copy link
Owner

Yes! Also the download works https://mtennekes.github.io/cols4all/paletteer.rds

Many thanks

@olivroy olivroy deleted the img-links2 branch October 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants