-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked settings #111
Reworked settings #111
Conversation
Add saving, generate selection idxs from settings list, order settings via index value in each group of settings
For now didn't really go through code but for formatting use spaces instead of tabs if you want specific alignment. edit: reasoning: tab width isn't defined anywhere and can be anything which in turn breaks alignment if done with tabs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test but LGTM 👍
No code change, only format Co-authored-by: SX <[email protected]>
Use spaces instead Co-authored-by: SX <[email protected]>
Committed your suggestions. Good for you ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but seems fine.
Using inline instead of multiples lines to add tooltip attached to setting into formspec Co-authored-by: SX <[email protected]>
This PR contains all from the new settings management. Let's explain a bit how it works :
init.lua
: here you defines the settingsmail.settings
: the whole list of settings withsetting = { -- data }
structuremail.settings_groups
: the list of groups of settings (for settings page)selected_idxs
sub-tables for each settingssettings.lua
: the redesigned ui pagex
andy
valuesindex
value (for the selected group)selected_idxs
the temporary valueInfo for settings definition :
type
(supported :string
,index
(for dropdowns),bool
(for checkboxes)),default
,group
,label
index
(recommended) : used to defines the order of the settings in the group on the UItooltip
: additional info at hoveringdataset
:index
types (dropdown), for example default sorting field (From/To, ...)format
: fordataset
, preview predefined values (for example format current date with%X ...
)Hope there's not too much bugs, I fixed all those I noticed. I'm surprised that it not contains too much new lines, and new settings implementation is now much easier.
And, as usual, a small screenshot :