Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A maillist is deleted instead of renamed #136

Closed
singularis-mzf opened this issue Jan 28, 2024 · 0 comments · Fixed by #137
Closed

A maillist is deleted instead of renamed #136

singularis-mzf opened this issue Jan 28, 2024 · 0 comments · Fixed by #137
Labels
Bug Something isn't working Release blocker No release until this is closed
Milestone
1.4.0

Comments

@singularis-mzf
Copy link
Contributor

How to reproduce:

  • Create a valid maillist with an arbitrary name, so that the list is the last in the list of maillists
  • Edit the maillist and change its name somehow (e. g. add X at the end of the name)
  • Save the edited maillist

Instead of changing name, the maillist will disappear permanently.

The cause is in ui/edit_maillists.lua:62 - a maillist is deleted after it's updated (mail.update_maillist() already removes the old list entry).
@BuckarooBanzay BuckarooBanzay added the Bug Something isn't working label Jan 28, 2024
singularis-mzf added a commit to singularis-mzf/mail that referenced this issue Jan 28, 2024
@singularis-mzf
fix for bugs mt-mods#135 and mt-mods#136
65ec90c
@S-S-X S-S-X linked a pull request Jan 28, 2024 that will close this issue
fix for bugs #135 and #136 #137
Merged
@Athozus Athozus added this to the 1.4.0 milestone Jan 28, 2024
@Athozus Athozus added the Release blocker No release until this is closed label Jan 28, 2024
Athozus added a commit that referenced this issue Feb 1, 2024
@singularis-mzf @Athozus @S-S-X
fix for bugs #135 and #136 (#137)
fcca0b7 
* fix for bugs #135 and #136

* Fix indentation in ui/compose.lua

Co-authored-by: SX <[email protected]>

---------

Co-authored-by: Athozus <[email protected]>
Co-authored-by: SX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Release blocker No release until this is closed
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

fix for bugs #135 and #136 singularis-mzf/mail
3 participants
@BuckarooBanzay @singularis-mzf @Athozus