Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #87

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Update README.md #87

merged 2 commits into from
Jul 28, 2021

Conversation

wojtekmach
Copy link
Contributor

No description provided.

@msz
Copy link
Owner

msz commented Jul 28, 2021

Thanks! Could you give some more context? The way I see it, the original wording works also in case someone does not import Mox and instead uses the functions directly, although your change is more precise. Perhaps it could be rephrased to "simply replace all occurrences of Mox with Hammox"?

@wojtekmach
Copy link
Contributor Author

A developer recently installed Hammox and I believe they interpreted it as if the only thing you need to do is replace :mox dependency with :hammox, that's it.

Perhaps it could be rephrased to "simply replace all occurrences of Mox with Hammox"?

Yeah, I think that works. I made it even a little bit more verbose, lmk what you think.

@msz
Copy link
Owner

msz commented Jul 28, 2021

Awesome!

@msz msz merged commit f94854c into msz:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants