Type-check stubs #58
Merged
Type-check stubs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2020
|
Thanks! I think the code looks great. For testing, I'd go a simpler way — I'd just make a test where we stub with a wrong function and try to call the stub, then assert that there was a Hammox exception thrown. This should ensure that stubs are being protected. |
|
@msz Great, thanks! I'll take care of that tomorrow. If you have a minute to drop a |
added 2 commits
October 12, 2020 08:00
Closes msz#56 Currently, only mocks created with `expect` are type-checked by Hammox. This provides the same protection for stubs created with `stub`.
Revert earlier change to `assert_pass`/`assert_fail`.
randycoulman
force-pushed
the
feat/protect-stubs
branch
from
f1a6b6d
to
28a29e5
Compare
|
@msz I've updated the tests as you suggested; I reverted my earlier change and added explicit tests of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #56
Currently, only mocks created with
expectare type-checked by Hammox.This provides the same protection for stubs created with
stub.There is also
stub_with, but I'm not sure how to add protection for that one; suggestions welcome!I wasn't sure how best to test this change. For now, I modified
assert_passandassert_failto usestubinstead ofexpect; there are a few other tests that continue to useexpect, so both code paths are being tested. I'm happy to change this up however you'd like.I extracted a helper named
wrapthat is now used in bothexpectandstub; I'd rather use the nameprotectedfor this, but that name's already taken. Again, I'm happy to change this however you'd like.