Demote the "pseudo console" support to opt-in #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pseudo console support is just a bit too buggy still: - When typing anything in an interactive Bash session before the prompt is shown, frequently the keystrokes are then replayed _twice_ when the prompt is active. Even worse: it seems that under certain circumstances (e.g. when spawning `less.exe` from a MINGW process), keystrokes are recorded while a process is active that wants to consume them but those recorded keystrokes are then replayed once the process finished (e.g. the `q` keystroke to exit `less.exe` will then be misinterpreted for interactive input in the Bash session). - When `vim` is called from a MINGW process, it seems that the terminal loses the `onlcr` property after the `vim` process finished, i.e. subsequently printed lines do not start at the beginning of the line anymore, but precisely where the previous line ended. - In `vim`, when selecting text visually (via the `v` keystroke), it seems that the selection is frequently reset while navigating with the arrow keys. There are probably quite a few more rough edges in the pseudo console feature, unfortunately. In light of these issues, it makes most sense to disable the pseudo console support and make it opt-in rather than opt-out. Signed-off-by: Johannes Schindelin <[email protected]>
It is simply the negation of `disable_pcon`, i.e. `MSYS=enable_pcon` is equivalent to `MSYS=nodisable_pcon` (the former is slightly more intuitive than the latter) and likewise `MSYS=noenable_pcon` is equivalent to `MSYS=disable_pcon` (here, the latter is definitely more intuitive than the former). This is needed because we just demoted the pseudo console feature to be opt-in instead of opt-out, and it would be awkward to recommend to users to use "nodisable_pcon"... "nodisable" is not even a verb. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to experiment with it, we now also support
MSYS=enable_pcon(in addition to the equivalent but unintuitiveMSYS=nodisable_pcon).