fixup! cygthread: suspend thread before terminating. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jeremyd2019
force-pushed
the
msys2-3.5.4-suppress-error-output
branch
from
d892c10
to
63dd325
Compare
jeremyd2019
commented
Nov 13, 2024
lazka
reviewed
Nov 13, 2024
Suppress error output if ReadFile on child wait pipe returns ERROR_OPERATION_ABORTED due to addition of CancelSynchronousIo call.
jeremyd2019
force-pushed
the
msys2-3.5.4-suppress-error-output
branch
from
63dd325
to
63686d1
Compare
|
For future reference, this was the issue this is fixing: #234 (comment) |
lazka
added a commit
to lazka/MSYS2-packages
that referenced
this pull request
Nov 14, 2024
lazka
added a commit
to msys2/MSYS2-packages
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress error output if ReadFile on child wait pipe returns ERROR_OPERATION_ABORTED due to addition of CancelSynchronousIo call.
@lazka can you test this, since you saw the error?